From 03ec29cd4f8cc3da9c773c3fb758c6f65cf8bee7 Mon Sep 17 00:00:00 2001 From: Kevin Sylvestre Date: Wed, 29 Jan 2020 22:33:23 -0800 Subject: [PATCH] Pin JSON version to fix specs on ruby head The `JSON` 2.3.0 gem changed how parsing errors are raised. For example: require 'json' data = {} data['cycle'] = data JSON.dump(data) With json v2.2.0: This raises a `SystemStackError`. With json v2.3.0: This causes `fatal (machine stack overflow in critical region)` Since the specs depend on 'SystemStackError' - pinning the version. --- .travis.yml | 1 + sentry-raven.gemspec | 1 + 2 files changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index d3cdaa5e2..f678a85b4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,6 +14,7 @@ rvm: - 2.4.9 - 2.5.7 - 2.6.5 + - 2.7.0 env: - RAILS_VERSION=4 diff --git a/sentry-raven.gemspec b/sentry-raven.gemspec index ad2876c21..13c715d93 100644 --- a/sentry-raven.gemspec +++ b/sentry-raven.gemspec @@ -18,4 +18,5 @@ Gem::Specification.new do |gem| gem.executables = "raven" gem.add_dependency "faraday", ">= 1.0" + gem.add_dependency "json", "<= 2.2.0" end