Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boto3 integration #896

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

marshall-lee
Copy link
Contributor

This is the integration for boto3 library for recording requests to AWS services as spans.

Another suggestion is to enable it by default in aws_lambda integration since boto3 package is pre-installed on every lambda.

Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, this looks good! I added a review but after that I think we can merge

sentry_sdk/integrations/boto3.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/boto3.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/boto3.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/boto3.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change then we can merge

This is the integration for boto3 library for recording
AWS requests as spans.

Another suggestion is to enable it by default in aws_lambda integration
since boto3 package is pre-installed on every lambda.
@marshall-lee
Copy link
Contributor Author

@untitaker CI is green now!

@untitaker untitaker merged commit ba1e550 into getsentry:master Oct 29, 2020
@marshall-lee marshall-lee deleted the integrations/boto3 branch October 29, 2020 15:35
@untitaker
Copy link
Member

Thanks! I think we should add integration docs like this one: https://docs.sentry.io/platforms/python/configuration/integrations/redis/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants