-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boto3 integration #896
Boto3 integration #896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, this looks good! I added a review but after that I think we can merge
9850803
to
ca6c4ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change then we can merge
This is the integration for boto3 library for recording AWS requests as spans. Another suggestion is to enable it by default in aws_lambda integration since boto3 package is pre-installed on every lambda.
ca6c4ec
to
48d8257
Compare
@untitaker CI is green now! |
Thanks! I think we should add integration docs like this one: https://docs.sentry.io/platforms/python/configuration/integrations/redis/ |
This is the integration for boto3 library for recording requests to AWS services as spans.
Another suggestion is to enable it by default in
aws_lambda
integration since boto3 package is pre-installed on every lambda.