feat(testing): Add pytest-watch #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Oct 12, 2020
untitaker
approved these changes
Oct 19, 2020
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
…not necessary anymore
…python into kmclb-add-pytest-watch
antonpirker
force-pushed
the
kmclb-add-pytest-watch
branch
2 times, most recently
from
4dbda07
to
00a6002
Compare
antonpirker
force-pushed
the
kmclb-add-pytest-watch
branch
from
00a6002
to
3d09944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
pytest-watchto the test requirements, in order to be able to runpytestin watch mode. It also fixes two places where we weren't closing resources at the end of a test. (Normally, they're closed by default because the testing process ends. But with a watcher it doesn't end, and causespytest-watchto complain about the abandoned resources.)