Add basic support for no_proxy environment variable #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this for #178? Implementation looks ok, will look tomorrow closer. I overlooked this but I think we may want some testcases for the lowercase envvar as that's hte one used by curl |
untitaker
approved these changes
Sep 28, 2020
|
Excellent, thanks! |
|
Yes, it was for #178 . Thanks for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would match
http_proxy/https_proxysupport and was actually supported in the old raven-python client.Given the lack of a standard on
no_proxyinterpretation (with/without asterisk, with IP CIDR, etc), I went with a first basic implementation that should cover the most frequent usecase.