feat: Improve type annotations in utils.py #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace some Anys with proper types.
untitaker
approved these changes
Jul 5, 2019
|
Thanks for your continued efforts on this @bluetech! |
|
@untitaker This has one failure left: It looks legitimate but I'm not sure. The Would you mind taking a look? |
|
Yeah, seems like i was a bit careless about the logic on that one |
bluetech
commented
Jul 5, 2019
sentry_sdk/utils.py
Outdated
| @@ -358,7 +358,10 @@ def safe_repr(value): | |||
|
|
|||
|
|
|||
| def filename_for_module(module, abs_path): | |||
| # type: (str, str) -> str | |||
| # type: (str, Optional[str]) -> Optional[str] | |||
There was a problem hiding this comment.
Looking at serialize_frame, module can be None too.
There was a problem hiding this comment.
You're right, not sure why mypy didn't catch that one. I think I fixed it now though!
untitaker
force-pushed
the
typings-improve-utils
branch
from
d014f7e
to
fb66204
Compare
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some Anys with proper types.