feat: tracing prototype #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
changed the title
dcramer
reviewed
May 24, 2019
untitaker
force-pushed
the
wip/sessiontracking
branch
from
9cde1cd
to
4881600
Compare
untitaker
force-pushed
the
wip/sessiontracking
branch
from
4881600
to
270ff43
Compare
bruno-garcia
requested changes
Jun 11, 2019
| from sentry_sdk import Hub | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("sample_rate", [0.0, 1.0]) |
There was a problem hiding this comment.
Where are the test!?!??! :D
This reverts commit ccec6ca.
bruno-garcia
approved these changes
Jun 19, 2019
HazAT
requested changes
Jun 21, 2019
| same_process_as_parent=True, | ||
| sampled=None, | ||
| transaction=None, | ||
| op=None, |
There was a problem hiding this comment.
Shouldn't we make operation required?
There was a problem hiding this comment.
For transaction/trace spans, none of the Pytohn SDK's integrations set either OP or description. Only for child spans.
There was a problem hiding this comment.
If we want to make more attrs required I'd like to discuss what the difference between transaction and description is
untitaker
force-pushed
the
wip/sessiontracking
branch
from
0554455
to
60ec0cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how the event payload is supposed to look, just went by what armin patched into semaphore. We get an unlabeled event in Sentry right now