Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff for linting/formatting #2527

Open
antonpirker opened this issue Nov 23, 2023 · 0 comments
Open

Use ruff for linting/formatting #2527

antonpirker opened this issue Nov 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@antonpirker
Copy link
Member

antonpirker commented Nov 23, 2023 •
edited

Would be nice to get rid of flake8 and black and only use ruff for all our linting/formatting. To make local development a bit easier and have all the configuration in one place.

mypy is still needed though, because ruff can not replace it.

Currently this is not possible, because ruff does not support type annotations in comments: astral-sh/ruff#1619

So this will be only something we can take on when we remove Python 2.7 support.
@antonpirker antonpirker added the enhancement New feature or request label Nov 23, 2023
@antonpirker antonpirker added this to the Sentry SDK 2.0 milestone Nov 23, 2023
@sentrivana sentrivana removed this from the Sentry SDK 2.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonpirker @sentrivana