fix(profiling): Start profiler thread lazily #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
changed the base branch from
master
to
txiao/tests/add-workflow-to-test-gevent
When running with uWSGI, it preforks the process so the profiler thread is started on the master process but doesn't run on the worker process. This means that no samples are ever taken. This change delays the start of the profiler thread to the first profile that is started.
Zylphrex
force-pushed
the
txiao/fix/start-profiler-thread-lazily
branch
from
1acca19
to
9fb3ace
Compare
Base automatically changed from
txiao/tests/add-workflow-to-test-gevent
to
master
February 21, 2023 14:46
antonpirker
approved these changes
Feb 22, 2023
sentry_sdk/profiler.py
Outdated
| self.pid = pid | ||
| self.running = True | ||
|
|
||
| self.thread = self.make_thread() |
There was a problem hiding this comment.
Why can ThreadPool(1) not be called here directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with uWSGI, it preforks the process so the profiler thread is started on the master process but doesn't run on the worker process. This means that no samples are ever taken. This change delays the start of the profiler thread to the first profile that is started.