Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud): Adding Cloud Resource Context #1882

Merged
merged 41 commits into from
Feb 27, 2023

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Feb 1, 2023

Fixes #1820

This is the cloud context definition in relay: getsentry/relay#1854

@antonpirker antonpirker changed the title Adding Cloud Context feat(serverless): Adding Cloud Context Feb 6, 2023
@antonpirker antonpirker marked this pull request as ready for review February 8, 2023 12:44
@antonpirker antonpirker changed the title feat(serverless): Adding Cloud Context feat(serverless): Adding Cloud Resource Context Feb 8, 2023
@antonpirker antonpirker changed the title feat(serverless): Adding Cloud Resource Context feat(cloud): Adding Cloud Resource Context Feb 8, 2023
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a fundamental question first, review will come after we've discussed that

sentry_sdk/integrations/cloudresourcecontext.py Outdated Show resolved Hide resolved
sentry_sdk/integrations/cloudresourcecontext.py Outdated Show resolved Hide resolved
@antonpirker
Copy link
Member Author

This is the cloud context definition in relay: getsentry/relay#1854

@antonpirker antonpirker dismissed sl0thentr0py’s stale review February 27, 2023 08:38

resolved discussion in slack.

@antonpirker antonpirker merged commit 5306eab into master Feb 27, 2023
@antonpirker antonpirker deleted the antonpirker/1820-cloud-context branch February 27, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cloud resource context
3 participants