Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for Starlette in FastAPI integration #1868

Merged
merged 3 commits into from Jan 30, 2023
Merged

Fix check for Starlette in FastAPI integration #1868

merged 3 commits into from Jan 30, 2023

Conversation

antonpirker
Copy link
Member

When loading FastAPI integration also check if StarletteIntegration can actually be loaded. (Because Starlette is a requirement for FastAPI)

Fixes #1603

@antonpirker antonpirker requested review from sl0thentr0py and removed request for sl0thentr0py January 30, 2023 08:37
@antonpirker antonpirker merged commit c2ed5ec into master Jan 30, 2023
@antonpirker antonpirker deleted the antonpirker/1603-cannot-import-startletteintegration branch January 30, 2023 14:21
@antonpirker antonpirker self-assigned this Jan 30, 2023
@thedch
Copy link

thedch commented Apr 3, 2023

Hi @antonpirker,

I'm still seeing this issue on sentry-sdk==1.18.0, is that expected? Let me know if there's any debug or mitigation steps I should take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@antonpirker @thedch @sl0thentr0py