Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Github action checks failing #1780

Merged
merged 28 commits into from Dec 14, 2022

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Dec 9, 2022

The checks are failing for 2 reasons

  1. Github actions dropped python3.6 support on the latest hosted runners.
    Python 3.6 x64 on Linux: Error: Version 3.6 with arch x64 not found actions/setup-python#544 (comment)
  2. New release of tox was validation the python version in the environment name
    and the trailing framework version being used in the environment name was
    being treated as a python version and validated causing an issue.

@Zylphrex Zylphrex force-pushed the txiao/fix/github-action-checks-failing branch from 4342ed0 to 7dba1f2 Compare December 9, 2022 22:14
@Zylphrex Zylphrex changed the title pin tox in lint job fix(ci): Github action checks failing Dec 9, 2022
The checks are failing for 2 reasons

1. Github actions dropped python3.7 support on the latest hosted runners.
   actions/setup-python#544 (comment)
2. New release of tox was validation the python version in the environment name
   and the trailing framework version being used in the environment name was
   being treated as a python version and validated causing an issue.
@Zylphrex Zylphrex force-pushed the txiao/fix/github-action-checks-failing branch from 7dba1f2 to ddcf9a3 Compare December 9, 2022 22:17
@Zylphrex Zylphrex force-pushed the txiao/fix/github-action-checks-failing branch from 75d6967 to 0b533f2 Compare December 12, 2022 21:02
@Zylphrex Zylphrex force-pushed the txiao/fix/github-action-checks-failing branch from 0b533f2 to 4906f43 Compare December 12, 2022 22:06
tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@antonpirker antonpirker marked this pull request as ready for review December 14, 2022 08:41
@antonpirker antonpirker merged commit dd26fbe into master Dec 14, 2022
@antonpirker antonpirker deleted the txiao/fix/github-action-checks-failing branch December 14, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants