Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Resolve inherited method class names #1756

Merged
merged 1 commit into from Nov 29, 2022

Conversation

Zylphrex
Copy link
Member

Methods may be inherited from a parent class. If multiple classes inherit from the same class and uses the inherited method, we'd want it to report the parent class's name instead of the individual child classes since they'd have the same filename and lineno of the parent class and not the children.

Methods may be inherited from a parent class. If multiple classes inherit from
the same class and uses the inherited method, we'd want it to report the parent
class's name instead of the individual child classes since they'd have the same
filename and lineno of the parent class and not the children.
@sl0thentr0py
Copy link
Member

sl0thentr0py commented Nov 29, 2022

just a footnote:
I'm wondering if we're missing some standardization in extracting meaningful names from frames, all of this seems like extra logic that should probably live somewhere more general upstream?

@Zylphrex
Copy link
Member Author

just a footnote: I'm wondering if we're missing some standardization in extracting meaningful names from frames, all of this seems like extra logic that should probably live somewhere more general upstream?

Yeah, this could potentially be something we port over to errors as well since names like __init__ isn't particularly meaningful without the class name. This was a major pain point when looking at profiles but if this can enhance the experience for errors, I think it makes sense for this logic to be more general.

@Zylphrex Zylphrex merged commit 1c886e6 into master Nov 29, 2022
@Zylphrex Zylphrex deleted the txiao/fix/resolve-inherited-method-class-names branch November 29, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants