feat(profiling): Extract more frame info #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zylphrex
force-pushed
the
txiao/feat/extract-more-frame-info-for-profiles
branch
from
1270f1c
to
a310801
Compare
Zylphrex
commented
Nov 7, 2022
Comment on lines
+275
to
+277
| handle_in_app_impl( | ||
| profile["frames"], options["in_app_exclude"], options["in_app_include"] | ||
| ) |
There was a problem hiding this comment.
If I understood the helper correctly, this does the following
- if no
in_app_excludeorin_app_includeare specified, it'll add"in_app": Trueto every frame - if it is specified
- frames that match
in_app_includewill have"in_app": Trueadded to it - frames that match
in_app_excludewill have"in_app": Falseadded to it - other frames will not specify, but we should treat them as if they're not in_app frames
- frames that match
sl0thentr0py
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts a little more information around the frame that we'll use to improve the visualization/groupings including