Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified naming of span "op"s #1643

Closed
antonpirker opened this issue Sep 27, 2022 · 2 comments · Fixed by #1661
Closed

Unified naming of span "op"s #1643

antonpirker opened this issue Sep 27, 2022 · 2 comments · Fixed by #1661
Assignees
Labels
enhancement New feature or request Hacktoberfest 🎃

Comments

@antonpirker
Copy link
Member

Problem Statement

For performance issues it is vital to have identical naming for span op parameter across SDKs. For this an audit was done and some of the span ops need to be renamed.

Solution Brainstorm

Make sure the span ops are name like defined here:
getsentry/develop#693 (comment)

@antonpirker antonpirker added enhancement New feature or request Status: Backlog labels Sep 27, 2022
@AbhiPrasad
Copy link
Member

AbhiPrasad commented Sep 27, 2022

Here is the list:

SDK Old Operation New Operation Link PR
Python
serverless.function function.aws.lambda
op="serverless.function",
aws.request http.client
aws.request.stream http.client.stream
op="aws.request.stream",
celery.submit queue.submit.celery
with hub.start_span(op="celery.submit", description=args[0].name) as span:
celery.task queue.task.celery
http http.client
op="http", description="%s %s" % (request.method, request.url)
redis db.redis
with hub.start_span(op="redis", description="redis.pipeline.execute") as span:
rq.task queue.task.rq
starlette.middleware middleware.starlette
op="starlette.middleware", description=middleware_name
django.view view.django
op="django.view", description=request.resolver_match.view_name
django.middleware middleware.django
op="django.middleware", description=description
django.template.render template.render
op="django.template.render",

@antonpirker
Copy link
Member Author

One item was missing:

SDK Old Operation New Operation Link PR
Python
serverless.function function.gcp
op="serverless.function",

@antonpirker antonpirker changed the title Update span "op"s Unified naming of span "op"s Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest 🎃
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants