Update Flask and Quart integrations #1520
Merged
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask and Quart are deprecating and removing the ``_xxx_ctx_stack``s and adopting a more direct usage of ContextVars. The previous code will therefore break for the latest version of Quart and start to warn for Flask and then break. This fix should work with any version of Flask or Quart, and hence is a more robust version. There is an extra indirection, however I don't think this is on any hot path.
antonpirker
requested changes
Jul 27, 2022
|
Hey @pgjones ! I have one request for making it backwards compatible. Otherwise it looks good! |
antonpirker
approved these changes
Aug 2, 2022
|
Hey again @pgjones! If you send me your shipping address to anton |dot| pirker \at\ sentry [dot] io, I can send you a couple of stickers as a small token of appreciation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flask and Quart are deprecating and removing the
_xxx_ctx_stacksand adopting a more direct usage of ContextVars. The previous code
will therefore break for the latest version of Quart and start to warn
for Flask and then break.
This fix should work with any version of Flask or Quart, and hence is
a more robust version. There is an extra indirection, however I don't
think this is on any hot path.