Forced Flask Version <2.1.0 Requirement Is Breaking Build

[dsoprea]

How do you use Sentry?

Sentry Saas (sentry.io)

Version

1.5.9

Steps to Reproduce

Sentry is suddenly requiring that Flask is <2.1.0 as of 1.5.9:

The changelog doesn't explain it:

The PR (#1379
) doesn't explain it, either. The commit doesn't really explain it other than to say that it's just to not break unit-tests:

(9a82f7b

However, this broke our build and not wanting to break Sentry's unit-tests is not an awesome reason for doing so. As a result, we're having to keep Sentry at 1.5.8 in order to unblock things. Can you explain more why this was necessary? Is there a timeline for getting this figured out so we can go back to using tip?

Dustin

Expected Result

No build conflict

Actual Result

Build conflict:

pkg_resources.ContextualVersionConflict: (Flask 2.1.1 (/usr/local/lib/python3.8/dist-packages), Requirement.parse('flask<2.1.0,>=0.11; extra == "flask"'), {'sentry-sdk'})

[antonpirker]

Hey @dsoprea !
Thanks for your message.

I think it was because there was a new Werkzeug release and with that the SDK did not work anymore so I had to pin the Flask version to make sure the old Werkzeug would be used. (or something like this.)

Does your project works in SDK 1.5.8 with the newest Flask and Werkzeug?

[dsoprea]

Yes, it should be. I'm pinning Sentry to 1.5.8 but everything else should be at tip, and, since it's a Docker build, there should be no environmental entanglements with older versions.

[antonpirker]

Ok, I created a PR where the version contraint is removed. Let's see what will happen in the test suite:
#1395

I remember I did this version constraint because a new version of some lib that the newest Flask uses broke the test suite. But I am not 100% sure what it was, because there where several new versions of libs that are dependencies of Flask that had a new release in the last couple of weeks that somehow manage to break the test suite.

[dsoprea]

Thanks for attending to this.

[antonpirker]

Hey @dsoprea !
We just released 1.5.10 that fixed this problem!

[antonpirker]

Thanks again for reporting this!
If you send me your shipping address to anton [dot] pirker {at} sentry (.) io I can send you a couple of stickers as a small "Thank you".