✨ Add support for setting transaction name to path in FastAPI #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
sl0thentr0py
approved these changes
Mar 17, 2022
|
thx for the contribution @tiangolo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Add support for setting transaction name to
pathin FastAPIThis is related to #829 and #1165
This would work with FastAPI
0.74.1that I just released 5 minutes ago.Most of the functionality is already tested by the Starlette tests. I added a FastAPI test only to test the new
transaction_style="url". But I'm not sure if that's desired. If it is, FastAPI would have to be added to the testing dependencies here, but I'm not even sure where, I suspect somewhere in the Tox configs, but I don't really know much about Tox 😬 , so I'll wait for feedback first.