record span and breadcrumb when Django opens db connection #1250
Conversation
| with capture_internal_exceptions(): | ||
| hub.add_breadcrumb(message="connect", category="query") | ||
|
|
||
| with hub.start_span(op="db", description="connect"): | ||
| return real_connect(self) |
There was a problem hiding this comment.
not sure what the message or description should be
There was a problem hiding this comment.
Think these are fine, we can iterate on them in the future if people give feedback
|
|
||
| from tests.integrations.django.myapp.wsgi import application | ||
|
|
||
| # Hack to prevent from experimental feature introduced in version `4.3.0` in `pytest-django` that | ||
| # requires explicit database allow from failing the test | ||
| pytest_mark_django_db_decorator = pytest.mark.django_db | ||
| pytest_mark_django_db_decorator = partial(pytest.mark.django_db) |
There was a problem hiding this comment.
I updated this so I could pass transaction=False
sl0thentr0py
requested review from
a team,
rhcarvalho and
AbhiPrasad
and removed request for
a team
|
Will wait for tests match against the django matrix to see if it works with all versions, but LGTM from an initial glance. Thank you for your contribution! |
|
The test failures are due to |
|
@AbhiPrasad I updated the branch |
There was a problem hiding this comment.
Seem like there some test failures, mind taking a look?
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-0.13.1
cachedir: .tox/py3.8-django-3.2/.pytest_cache
django: settings: tests.integrations.django.myapp.settings (from ini)
rootdir: /home/runner/work/sentry-python/sentry-python, configfile: pytest.ini
plugins: asyncio-0.16.0, hypothesis-6.24.5, localserver-0.5.0, forked-1.1.3, django-4.4.0, cov-2.8.1
collected 51 items
........F.
tests/integrations/django/test_basic.py ............Xx................ [ 54%]
tests/integrations/django/test_transactions.py ..... [ 64%]
tests/integrations/django/asgi/test_asgi.py .......
=================================== FAILURES ===================================
__________________________ test_django_connect_trace ___________________________
tests/integrations/django/test_basic.py:428: in test_django_connect_trace
assert res.status_code == 200
E AttributeError: 'tuple' object has no attribute 'status_code'
|
@AbhiPrasad I think I finally fixed it. I was incorrectly using the test client like the Django Rest client. |
|
Awesome, thanks for sticking with this! Will merge after I double check one thing. |
Here's a screenshot of a trace where Django opens a new connection
fixes #1249