New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-lambda): Add Python 3.9 support #1239
Conversation
tomscytale
commented
Nov 3, 2021
- Added AWS Lambda Python 3.9 runtime support
- Ignore mypy module check
- Fixed check bug and added python3.9 runtime to tests
- Revert comment
- run black on aws_lambda.py and test
- add python3.9 as compatible runtime in .craft.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for your contribution!
@AbhiPrasad thanks . What's with the test failures? They look spurious. |
Yup they seem to be flaky tests for sanic, we’ll take care of that before merging in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing, @tomscytale! I think we should fix master before merging this PR, what do you think @AbhiPrasad?
Master should be fixed, please rebase. |
2c688d0
to
34378a1
Compare
@AbhiPrasad done |