fix: integration with Apache Beam 2.32, 2.33 reported in #1231 #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Oct 29, 2021
AbhiPrasad
reviewed
Oct 29, 2021
galuszkak
force-pushed
the
feature/fix-sentry-beam
branch
from
85fbc45
to
66cb307
Compare
|
@AbhiPrasad fixed. I've amended existing commit so it's clean PR. |
galuszkak
force-pushed
the
feature/fix-sentry-beam
branch
from
66cb307
to
5f7131c
Compare
|
@AbhiPrasad I think failing tests are unrelated because they are failing on Sanic. I believe this failing change is tracked here: |
|
Yup unrelated test failures, we will merge regardless. |
If the tests are failing on Sanic's behalf related to that issue, then I am assuming it must be installing latest version which requires this to be merged: #1212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.