Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure that an envelope is cloned before it's modified #1206

Merged
merged 1 commit into from Sep 27, 2021
Merged

fix: Ensure that an envelope is cloned before it's modified #1206

merged 1 commit into from Sep 27, 2021

Conversation

mitsuhiko
Copy link
Member

Previously the envelope was modified in place which meant that an envelope could not be easily sent to multiple transports. Now the http transport makes a copy of the envelope before modifying it.

untitaker
untitaker approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving without tests ; Armin will look into making the Envelope class immutable (on mypy/type level) such that we eliminate this source of bugs

@mitsuhiko mitsuhiko merged commit 7d21816 into master Sep 27, 2021
@mitsuhiko mitsuhiko deleted the feature/add-envelope-copy branch September 27, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitsuhiko @untitaker