SentryWrappingMiddleware does not expose details of wrapped middleware

[MattFisher]

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
Python sentry-sdk==1.1.0

Steps to Reproduce

Use the python sentry sdk alongside the python NewRelic agent (newrelic-python-agent v6.4.4.161).
Wait for slow transaction traces to appear in NewRelic UI.

Expected Result

The middleware entries in transaction traces should show the names of the middlewares being wrapped.

Actual Result

All middlewares in transaction traces appear listed as sentry_sdk.integrations.django_middleware:_wrap_middleware.<locals>.SentryWrappingMiddleware, as shown in the screenshot below.

I've done some investigation, and the NewRelic agent determines the strings to be displayed
via a callable_name function, that bottoms out in a function called _object_context_py3. This function returns the module name (via object.__module__) and object.__qualname__ attributes of the passed object.

In the sentry_sdk.integrations.django.middleware._wrap_middleware function, the SentryWrappingMiddleware is given the wrapped middleware's __name__ attribute.

	if hasattr(middleware, "__name__"):
        SentryWrappingMiddleware.__name__ = middleware.__name__

In the standard library's functools.wraps(), the wrapping entity is given ('__module__', '__name__', '__qualname__', '__doc__', '__annotations__') of the wrapped object. This implies it should be pretty safe to do the same with SentryWrappingMiddleware, like so:

    if hasattr(middleware, "__name__"):
        SentryWrappingMiddleware.__name__ = middleware.__name__
    if hasattr(middleware, "__module__"):
        SentryWrappingMiddleware.__module__ = middleware.__module__
    if hasattr(middleware, "__qualname__"):
        SentryWrappingMiddleware.__qualname__ = middleware.__qualname__

or potentially

    for attr in ('__name__', '__module__', '__qualname__', '__doc__', '__annotations__'):
        if hasattr(middleware, attr):
            setattr(SentryWrappingMiddleware, attr, getattr(middleware, attr))

After manually making the first code change listed above, the results were what was expected:

[DmytroLitvinov]

I have faced the same issue 👀

[HazAT]

@MattFisher thanks for the awesome issue!
Would you mind making a PR out of this since it seems you solved it yourself?
We are happy to merge it and make it better for everyone, wdyt?

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[DmytroLitvinov]

Hi @HazAT ,
Could you please review related PR #1202 for that?

[nicon89]

We have same problem. Is there any plan for fixing it?

[sl0thentr0py]

fixed by #1202, will be in next release