Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan recipe for sentry-native #79

Closed
tonka3000 opened this issue Oct 29, 2019 · 4 comments
Closed

conan recipe for sentry-native #79

tonka3000 opened this issue Oct 29, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@tonka3000
Copy link

Hey @jan-auer ,

as discussed today here is an conan recipe for sentry-native https://github.com/tonka3000/conan-sentry_native .

It's not finished (see travis and appveyor), but I think you get the point 馃槃

Greetings

@Swatinem Swatinem added the enhancement New feature or request label Mar 10, 2020
@Swatinem
Copy link
Member

I just had a very brief look at conan, and it sounds nice to have.

We just merged a big rewrite in C, and switching to CMake for builds. Feel free to open a PR for this, however I don鈥檛 think this will be a priority from our team anytime soon.

@Croydon
Copy link

Croydon commented Mar 10, 2020

If anyone wants to tackle this, I would recommend to directly contribute a Conan recipe to the central, official Conan recipe repository called Conan Center Index 馃槃

https://github.com/conan-io/conan-center-index

@tonka3000
Copy link
Author

You are right @Croydon conan center index would be a better place. The recipe should be now easier because sentry native is now based on cmake.
When I find some time I will contribute it to the conan center index.

@Swatinem
Copy link
Member

The recipe should be now easier because sentry native is now based on cmake.

BTW, I would very much appreciate feedback on the CMake parts, I have no idea if they are correct this way, or how they could be further improved.

I will contribute it to the conan center index

If moving this to the index is the way to go, I will close this issue. Feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants