Support using SENTRY_RELEASE environment variable #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What exactly is not working with setting Also this PR enables running a shell command by default which we are not doing for a few reasons (mainly security and performance). Edit: I ofcourse forgot about config caching 😄 that is when it won't work. |
stayallive
requested changes
Oct 23, 2022
There was a problem hiding this comment.
@cleptric I'm not sure we even want to keep the git command example in the config file, it's been around since forever and it's been kept but this might be better documented elsewhere because this is not the most efficient way to achieve this anyway.
stayallive
approved these changes
Oct 27, 2022
cleptric
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PHP SDK docs a user can set the
SENTRY_RELEASEenvironment variable. But with the Laravel specific package thereleaseoption is commented out and not using the default value.