Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always start performance tracing #600

Merged
merged 8 commits into from Oct 27, 2022
Merged

Conversation

stayallive
Copy link
Collaborator

As mentioned in #595, we are incorrectly "guarding" against enabling performance tracing when no sample rate or sampler callback is set. This removes that check and always enables performance tracing.

This has minimal impact on the users application since we always check if there is an active transaction/span before doing any real work so most code becomes a no-op if the transaction is not sampled.

This should be merged to master after #587.

This will also have no real work effect until getsentry/sentry-php#1405 has been solved.

Base automatically changed from 3.x to master October 18, 2022 15:22
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: We have to bump sentry/sentry to ^3.10.
And while we're at it, sentry/sdk to ^3.3.

h: Middleware::hydrateResponseData() throws an Call to a member function setHttpStatus() on null error, when traces_sample_rate is set to0.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry/Laravel/Tracing/EventHandler.php Outdated Show resolved Hide resolved
@cleptric cleptric linked an issue Oct 23, 2022 that may be closed by this pull request
@stayallive stayallive merged commit 7919690 into master Oct 27, 2022
@stayallive stayallive deleted the fix-parent-tracing-logic branch October 27, 2022 11:11
@cleptric cleptric added this to the 3.0.1 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SDK assumes a trace_sample_rate of 0 means we don't want to trace
2 participants