New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always start performance tracing #600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h:
We have to bump sentry/sentry
to ^3.10
.
And while we're at it, sentry/sdk
to ^3.3
.
h:
Middleware::hydrateResponseData()
throws an Call to a member function setHttpStatus() on null
error, when traces_sample_rate
is set to0
.
cleptric
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #595, we are incorrectly "guarding" against enabling performance tracing when no sample rate or sampler callback is set. This removes that check and always enables performance tracing.
This has minimal impact on the users application since we always check if there is an active transaction/span before doing any real work so most code becomes a no-op if the transaction is not sampled.
This should be merged to
master
after #587.This will also have no real work effect until getsentry/sentry-php#1405 has been solved.