Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup event handlers #592

Merged
merged 8 commits into from Oct 17, 2022
Merged

Cleanup event handlers #592

merged 8 commits into from Oct 17, 2022

Conversation

stayallive
Copy link
Collaborator

This resolves issues where nested operations (like nested queue jobs) were not correctly handling the nesting and messing up the trace.

Also cleaned up and bundled some container resolving for the Dispatcher class.

And removed some @internal methods since they seemed much boilerplate for just a proxy.

This just needs a good test with actual async queues, but we can do that with the final 3.x tests.

@cleptric cleptric added this to the 3.0.0 milestone Oct 14, 2022
@cleptric cleptric mentioned this pull request Oct 14, 2022
19 tasks
@cleptric cleptric merged commit 0d5d9a0 into 3.x Oct 17, 2022
@cleptric cleptric deleted the cleanup-tracing-event-handler branch October 17, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants