Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Sentry meta tag retrieval #586

Merged
merged 1 commit into from Oct 12, 2022
Merged

Simplify Sentry meta tag retrieval #586

merged 1 commit into from Oct 12, 2022

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Oct 10, 2022

This simplifies echo'ing the Sentry meta for the end-user by just needing to call:

Sentry\Laravel\Integration::sentryMeta();

This makes it easier than needing (and documenting) to do:

Sentry\Laravel\Integration::sentryTracingMeta();
Sentry\Laravel\Integration::sentryBaggageMeta();

We could even drop the "seperate" methods or make them private / internal. But keeping them around for now makes this a non-bc change which saves one more step users need to take when upgrading (but might be worth still... to be discussed).

@cleptric cleptric mentioned this pull request Oct 11, 2022
19 tasks
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff :shipit:

We could leave the methods and point people to sentryMeta via docs.
This makes the upgrade less painful imo.

@cleptric cleptric marked this pull request as ready for review October 12, 2022 09:05
@cleptric cleptric merged commit 3cfb462 into 3.x Oct 12, 2022
@cleptric cleptric deleted the simplify-sentry-meta branch October 12, 2022 09:06
cleptric pushed a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants