Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Status code not populated on transaction if response did not inherit from the Laravel Response class #573

Merged
merged 4 commits into from Sep 29, 2022
Merged

fix: Status code not populated on transaction if response did not inherit from the Laravel Response class #573

merged 4 commits into from Sep 29, 2022

Conversation

ydwis40
Copy link
Contributor

@ydwis40 ydwis40 commented Sep 29, 2022

Fixing terminate method if return is JsonResponse instance

@ydwis40
Fix tracing not finished if using JsonResponse
5008774 
Fixing terminate method if return is JsonResponse instance
@stayallive stayallive changed the title Fix tracing not finished if using JsonResponse fix: Fix status code not populated on transaction if response did not inherit from the Laravel Response class Sep 29, 2022
@stayallive stayallive changed the title fix: Fix status code not populated on transaction if response did not inherit from the Laravel Response class fix: Status code not populated on transaction if response did not inherit from the Laravel Response class Sep 29, 2022
cleptric
cleptric approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys!

@stayallive stayallive merged commit fc510b4 into getsentry:master Sep 29, 2022
@cleptric cleptric added this to the 2.14.0 milestone Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

@cleptric cleptric cleptric approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ydwis40 @stayallive @cleptric