New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw URLs sent as Transaction #562
Comments
for more context, to improve the performance product experience, we are working to improve transaction naming meaning that in product we don't have a ton of unique transactions because of poor parameterization from different platforms Meaning the org slug |
and sentry-symphony sends URLs for everything |
@jan-auer is there some data we can share with @stayallive regarding
for option we we agreed to exclude similar to other SDKs it is not useful |
This comment was marked as outdated.
This comment was marked as outdated.
@stayallive We should take this into consideration for the DS rollout. |
So to summarize, we should exclude the following transactions by default:
For the 404's there are 2 types, the ones where there is no matching route (which defaults to a 404) or where there is a route but the developer throws a 404 because of a incorrect ID or some other reason. I assume we only want to exclude the first type not the second? In addition to that, do we allow developers to override this behaviour in some way if they do want to see OPTIONS in their transactions for some reason? |
The biggest "issue" right now are the hard 404's for missing routes. In regards to OPTIONS requests, there are currently some discussions from SDK folks going on internally, so we can wait and leave these transactions as is for the time being. |
Done in #583 and to be released in v3.0.0 |
Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
sentry-laravel 2.12.0
Steps to Reproduce
Sending transactions
Expected Result
High quality transactions
Actual Result
for sentry laravel (2.12.0) we're getting raw URLs and bad transactions. we noticed:
The text was updated successfully, but these errors were encountered: