Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw URLs sent as Transaction #562

Closed
Tracked by #587
smeubank opened this issue Aug 1, 2022 · 8 comments
Closed
Tracked by #587

Raw URLs sent as Transaction #562

smeubank opened this issue Aug 1, 2022 · 8 comments
Assignees
Milestone

Comments

@smeubank
Copy link
Member

smeubank commented Aug 1, 2022

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
sentry-laravel 2.12.0

Steps to Reproduce

Sending transactions

Expected Result

High quality transactions

Actual Result

for sentry laravel (2.12.0) we're getting raw URLs and bad transactions. we noticed:

  • OPTIONS has raw URLs. probably shouldn't be recorded to begin with
  • there's a bunch of transactions reported without http.method
  • 404s are missing the http.status, and those also come with raw URLs
@smeubank
Copy link
Member Author

smeubank commented Aug 1, 2022

for more context, to improve the performance product experience, we are working to improve transaction naming

meaning that in product we don't have a ton of unique transactions because of poor parameterization from different platforms

Meaning the org slug …/sentry/… becomes …/:orgId/…

  1. all web SDKs should now send source: dev spec
  2. DSC spec regarding transaction name quality

@smeubank
Copy link
Member Author

smeubank commented Aug 4, 2022

and sentry-symphony sends URLs for everything

@smeubank
Copy link
Member Author

smeubank commented Aug 4, 2022

@jan-auer is there some data we can share with @stayallive regarding

there's a bunch of transactions reported without http.method

for option we we agreed to exclude similar to other SDKs it is not useful

@github-actions

This comment was marked as outdated.

@cleptric
Copy link
Member

cleptric commented Oct 5, 2022

@stayallive We should take this into consideration for the DS rollout.

@cleptric cleptric added this to the 2.15.0 milestone Oct 5, 2022
@stayallive
Copy link
Collaborator

stayallive commented Oct 6, 2022

So to summarize, we should exclude the following transactions by default:

  • 404's (hard 404's for missing routes)
  • OPTIONS requests (mostly because of CORS)

For the 404's there are 2 types, the ones where there is no matching route (which defaults to a 404) or where there is a route but the developer throws a 404 because of a incorrect ID or some other reason. I assume we only want to exclude the first type not the second?

In addition to that, do we allow developers to override this behaviour in some way if they do want to see OPTIONS in their transactions for some reason?

@cleptric
Copy link
Member

cleptric commented Oct 6, 2022

The biggest "issue" right now are the hard 404's for missing routes.
This creates alerts in the product, with no way for the user to fix it.

Screenshot 2022-10-05 at 16 12 53

In regards to OPTIONS requests, there are currently some discussions from SDK folks going on internally, so we can wait and leave these transactions as is for the time being.

@cleptric
Copy link
Member

Done in #583 and to be released in v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants