Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move request info tracking to the middleware #408

Merged
merged 3 commits into from Nov 3, 2020

Conversation

stayallive
Copy link
Collaborator

Reason for this is that the route matched event is not always fired (Apiato is a good example) and sometimes the data is also not correctly attached to the transaction but a span which makes it useless.

So we hydrate request and response information just before finishing the transaction in the middleware.

@stayallive stayallive merged commit be92d66 into master Nov 3, 2020
@stayallive stayallive deleted the move-request-info-tracking branch November 3, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants