Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stripping the base namespace for route name #406

Merged
merged 2 commits into from Nov 2, 2020

Conversation

stayallive
Copy link
Collaborator

So I might a mistake in the stripping of the base namespace and used ltrim but that takes a character list and not a string so you could end up with some crazy route names that make no sense at all!

Fixed by using a Laravel string helper that does do what we want.

@stayallive stayallive requested a review from HazAT October 29, 2020 13:45
@stayallive stayallive marked this pull request as ready for review October 29, 2020 13:47
@stayallive stayallive merged commit 23c14c3 into master Nov 2, 2020
@stayallive stayallive deleted the feature/fix-stripping-away-base-namespace branch November 2, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant