Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to undefined method Sentry\Laravel\Tracing\ViewEngineDecorator::startLivewireRendering() #394

Closed
ziming opened this issue Oct 1, 2020 · 5 comments · Fixed by #395
Closed

Comments

@ziming
Copy link

ziming commented Oct 1, 2020

I'm using Livewire 1 if it helps.

Downgrading sentry to 2.0 from 2.0.1 works.

@stayallive
Copy link
Collaborator

Downgrading sentry to 2.0 from 2.0.1 works.

This sounds like an upgrade... :) Downgrading to 1.9 you mean?

It definitely helps to know you are using Livewire (although the error gave it away a bit), I'd have to look into it but I assume there are some clashes between our tracing setup and Livewire.

I'd advise you to stay on 1.9.x until we resolve it! Thanks for reporting!

@ziming
Copy link
Author

ziming commented Oct 1, 2020

I downgrade it to 2.0, not 1.9

Things still work at 2.0 for me.

@stayallive
Copy link
Collaborator

stayallive commented Oct 1, 2020

2.0 has the broken code so that puzzles me... however I found and fixed the issue and that should be released in the next bugfix release. The PR: #395.

Feel free to test it out by changing your composer.json to include:

"sentry/sentry-laravel": "dev-dev-feature/actually-decorate-the-view-engine@dev"

Don't forget to change this back to the "normal" versions after testing and after this is released:

"sentry/sentry-laravel": "^2.0"

Note when testing: The error only occurs on views that have Livewire components in them.

@lukerenfrew
Copy link

Just experienced this issue and got it working by implementing the exact code in the PR. Came here to see if I could submit a pull request and saw this.

Checked out the branch and it solves the issue 👍

Thanks for your work on this

@stayallive
Copy link
Collaborator

2.1.0 was just released which should fix this, thank you all for your reports and testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants