From d72279ae295b40cc951541a96901e0f28579462b Mon Sep 17 00:00:00 2001 From: zhifu Date: Thu, 27 Oct 2022 21:07:31 +0800 Subject: [PATCH] fix(tracing): add new transaction source --- packages/tracing/src/transaction.ts | 2 +- packages/types/src/transaction.ts | 2 ++ packages/vue/src/router.ts | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/tracing/src/transaction.ts b/packages/tracing/src/transaction.ts index 83d5d14e419f..346f1bf7a398 100644 --- a/packages/tracing/src/transaction.ts +++ b/packages/tracing/src/transaction.ts @@ -44,7 +44,7 @@ export class Transaction extends SpanClass implements TransactionInterface { this._name = transactionContext.name || ''; this.metadata = { - source: 'custom', + source: 'initialize', ...transactionContext.metadata, spanMetadata: {}, changes: [], diff --git a/packages/types/src/transaction.ts b/packages/types/src/transaction.ts index 3859438866d0..601513aa82fc 100644 --- a/packages/types/src/transaction.ts +++ b/packages/types/src/transaction.ts @@ -177,6 +177,8 @@ export interface TransactionMetadata { * whether or not to scrub identifiers from the transaction name, or replace the entire name with a placeholder. */ export type TransactionSource = + /** initialize name */ + | 'initialize' /** User-defined name */ | 'custom' /** Raw URL, potentially containing identifiers */ diff --git a/packages/vue/src/router.ts b/packages/vue/src/router.ts index f782246e8fb2..a5f9a8ecb348 100644 --- a/packages/vue/src/router.ts +++ b/packages/vue/src/router.ts @@ -92,7 +92,7 @@ export function vueRouterInstrumentation(router: VueRouter): VueRouterInstrument if (startTransactionOnPageLoad && isPageLoadNavigation) { const pageloadTransaction = getActiveTransaction(); if (pageloadTransaction) { - if (pageloadTransaction.metadata.source !== 'custom') { + if (pageloadTransaction.metadata.source !== 'initialize') { pageloadTransaction.setName(transactionName, transactionSource); } pageloadTransaction.setData('params', data.params);