Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breadcrumbs): Send component names on UI breadcrumbs #9946

Merged
merged 5 commits into from Dec 21, 2023
Merged

feat(breadcrumbs): Send component names on UI breadcrumbs #9946

merged 5 commits into from Dec 21, 2023

Conversation

0Calories
Copy link
Contributor

One of the PRs scoped from #9855

Sends component names on UI event breadcrumbs

@0Calories 0Calories self-assigned this Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.84 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.21 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.83 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.78 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.36 KB (+0.25% 🔺)
@sentry/browser - Webpack (gzipped) 22.04 KB (+0.41% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.27 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.93 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.09 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.09 KB (+0.37% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 203.62 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 93.5 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.43 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.06 KB (+0.07% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.62 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.08 KB (+0.41% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.26 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.89 KB (+0.04% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.6 KB (0%)

@0Calories 0Calories mentioned this pull request Dec 20, 2023
Closed
AbhiPrasad
AbhiPrasad reviewed Dec 21, 2023
View reviewed changes
packages/browser/src/integrations/breadcrumbs.ts Outdated
};

if (componentName) {
breadcrumb.data = { componentName };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this ui.component_name and align it with the other setting of data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do 👍

@0Calories 0Calories enabled auto-merge (squash) December 21, 2023 17:57
@0Calories 0Calories merged commit f819d81 into develop Dec 21, 2023
73 of 75 checks passed
@0Calories 0Calories deleted the feat/component-name-in-breadcrumbs branch December 21, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees

@0Calories 0Calories

Labels
ci-skip-cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0Calories @AbhiPrasad