Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): Add types field to package.json exports #9926

Merged
merged 1 commit into from Dec 20, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 20, 2023

Looks like we need to add a types field to the "." subpath in the exports object in package.json so that svelte-check type checking finds the type declarations of the SDK in Kit 2.0.

fixes #9923

@Lms24 Lms24 requested review from lforst and mydea December 20, 2023 10:19
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.39 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.79 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.39 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.39 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.04 KB (0%)
@sentry/browser - Webpack (gzipped) 21.69 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.79 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.51 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.71 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.77 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.36 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.28 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.34 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.62 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.17 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 21.72 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.93 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.57 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.35 KB (0%)

@Lms24 Lms24 merged commit c4d4022 into develop Dec 20, 2023
53 checks passed
@Lms24 Lms24 deleted the lms/fix-sveltekit-types-exports branch December 20, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import sentry in sveltekit v2 setup
2 participants