feat(nextjs): Connect server component transactions if there is no incoming trace #9845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap-servercomponents
…ect-server-component-traces
…ver-component-traces
size-limit report 📦
|
Base automatically changed from
lforst-refactor-wrap-servercomponents
to
develop
December 18, 2023 11:48
lforst
commented
Dec 18, 2023
Comment on lines
-160
to
-161
| // Remove routing groups: https://beta.nextjs.org/docs/routing/defining-routes#example-creating-multiple-root-layouts | ||
| .replace(/\/(\(.*?\)\/)+/g, '/') |
There was a problem hiding this comment.
Sneaking this in. This is actually a bug because routing groups should part of the txn name. I added this when I didn't fully understand the app router yet.
AbhiPrasad
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9816
With this PR we will connect the transactions of server components and generation functions for requests that do not have an incoming trace. This is usually the case for pageloads.
We do this based on a "shared object". Right now this shared object is the
headersobject. It has the same identity for all server components that are invoked in the context of one request.