Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hub & Scope handling #9841

Closed
8 tasks done
Tracked by #9508
mydea opened this issue Dec 14, 2023 · 0 comments
Closed
8 tasks done
Tracked by #9508

Update Hub & Scope handling #9841

mydea opened this issue Dec 14, 2023 · 0 comments
Assignees
@mydea
Milestone
8.0.0

Comments

@mydea
Copy link
Member

mydea commented Dec 14, 2023 •
edited

We need to implement getsentry/rfcs#122.

Tasks
Beta Give feedback
  3. feat(core): Add getGlobalScope() method #9920
    mydea
  5. feat(core): Extract scope application to util #9804
    mydea
  6. feat(core): Deprecate configureScope #9887
    mydea
  7. feat(core): Deprecate pushScope & popScope #9890
    mydea
@mydea mydea added this to the 8.0.0 milestone Dec 14, 2023
@mydea mydea mentioned this issue Dec 14, 2023
Closed
@mydea mydea self-assigned this Dec 14, 2023
@mydea mydea mentioned this issue Dec 14, 2023
Merged
mydea added a commit that referenced this issue Dec 15, 2023
@mydea
ref: Use getCurrentScope()/hub.getScope() instead of `configureSc…
1e8d2b3 
…ope()` (#9846)

In preparation for
#9841, as we want
to deprecate `configureScope`, refactor our own usage of this away.

I used a new transformer of sentry-migr8 for this, which did most of the
heavy lifting. I only needed to fix the block usage (which is more a
stylistic issue than an actual problem).

In some follow up, I'll also create a migr8 transform to refactor hub
usage away, to e.g. refactor `getCurrentHub().getScope()` to
`getCurrentScope()` etc. But for now this is OK I think.
@mydea mydea pinned this issue Dec 18, 2023
@mydea mydea closed this as completed Feb 19, 2024
@HazAT HazAT unpinned this issue Mar 1, 2024
@stephanie-anderson stephanie-anderson mentioned this issue Mar 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@mydea