Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Catch rejecting flushes #9811

Merged
merged 1 commit into from Dec 13, 2023
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Dec 13, 2023

We missed catching flushes in a few places which could cause problems if there are issues when sending events.

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.04 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.38 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.99 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.74 KB (0%)
@sentry/browser - Webpack (gzipped) 21.39 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 71.61 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 63.33 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.67 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.72 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 199.58 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.94 KB (+0.06% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.92 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.34 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.75 KB (0%)
@sentry/react - Webpack (gzipped) 21.44 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.48 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.23 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

@lforst lforst merged commit be32c1e into develop Dec 13, 2023
56 checks passed
@lforst lforst deleted the lforst-fix-lambda-leakage branch December 13, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants