Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deno): Optionally instrument Deno.cron #9808

Merged
merged 12 commits into from Dec 13, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 12, 2023

Adds check-in instrumentation to Deno.cron via the DenoCron integration.

Closes #9700

  • This requires v1.38 of Deno run with the --unstable flag.
  • The deno published types we auto download do not include unstable features, so I had to get them from deno types --unstable and check them into this PR
  • I've tested this feature but with a minimum cron schedule of 1 minute, I'm not sure how we can test that in CI

@timfish timfish changed the title feat(deno): Automatically instrument Deno.cron feat(deno): Optionally instrument Deno.cron Dec 13, 2023
@AbhiPrasad
Copy link
Member

Can we update the crons docs on https://docs.sentry.io/platforms/javascript/guides/deno/crons/?

Seems like we need to show the JS instructions.

@AbhiPrasad AbhiPrasad merged commit 41c7782 into getsentry:develop Dec 13, 2023
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic instrumentation of Deno crons
2 participants