feat(replay): Capture hydration error breadcrumb #9759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a hydration error breadcrumb for nextjs / other ssr frameworks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
size-limit report 📦
|
billyvg
reviewed
Dec 11, 2023
scttcper
changed the title
|
i don't know how reviews work in this repo so i tagged some names i saw in blame |
AbhiPrasad
reviewed
Dec 12, 2023
There was a problem hiding this comment.
We can cut a release asap to get this out after we merge in.
IMO doesn't feel amazing to have react specific logic in replay integration like this, but there's not really a better place to keep it I guess :/
In the future, you can tag @getsentry/ team-web-sdk-frontend (no space) and it'll round robin two of of the js sdk maintainers to review.
|
renamed to |
AbhiPrasad
approved these changes
Dec 12, 2023
ryan953
added a commit
to getsentry/sentry
that referenced
this pull request
Dec 13, 2023
…eplay Details page (#61477) Reads the new `session-replay-show-hydration-errors` feature flag which controls if we show `replay.hydrate-error` crumbs on the Replay Details page. These crumbs have a poor design right now, but they have a button which will open a Modal that shows a visual side-by-side comparison of before & after the hydration error happened. Also, it shows a diff of the html. <img width="1426" alt="SCR-20231208-ninr" src="https://github.com/getsentry/sentry/assets/187460/2b5b172d-024d-4535-98d9-86493405c523"> Depends on #61612 See related SDK change: getsentry/sentry-javascript#9759 fixes #61613 --------- Co-authored-by: Scott Cooper <scttcper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hydration error breadcrumb
replay.hydrate-errorfor nextjs / other react ssr frameworks.fixes #9649