Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Don't attach resource size if null #9669

Merged
merged 2 commits into from Nov 28, 2023

Conversation

AbhiPrasad
Copy link
Member

Resource size can be null in some browsers, so don't set it if it's null (only set integers).

@AbhiPrasad AbhiPrasad requested review from a team, mydea and ale-cota and removed request for a team November 27, 2023 16:40
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.86 KB (-0.24% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.46 KB (+5.8% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.12 KB (-0.24% 🔽)
@sentry/browser - Webpack (gzipped) 21.38 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.72 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.53 KB (+0.2% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.6 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.46 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.32 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.29 KB (+0.27% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.22 KB (+0.29% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.25 KB (-0.28% 🔽)
@sentry/react - Webpack (gzipped) 21.42 KB (-0.12% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (-0.25% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (-0.22% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (-0.02% 🔽)

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@AbhiPrasad AbhiPrasad merged commit 3476772 into develop Nov 28, 2023
87 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-resource-size-null-check branch November 28, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants