Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(feedback): Change form box-shadow to use CSS var #9630

Merged
merged 1 commit into from Nov 30, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Nov 21, 2023

This makes it consistent with the buttons box shadow, so they both have the same box shadow by default.

This makes it consistent with the buttons box shadow, so they both have the same box shadow by default.
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.62 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 55.73 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.02 KB (0%)
@sentry/browser - Webpack (gzipped) 21.33 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.05 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.14 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.27 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 195.75 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 88.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 63.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.86 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 65.93 KB (0%)
@sentry/react - Webpack (gzipped) 21.37 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.67 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.16 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.09 KB (-0.12% 🔽)

@billyvg billyvg marked this pull request as ready for review November 22, 2023 01:49
@billyvg billyvg merged commit b7fdb7d into develop Nov 30, 2023
81 checks passed
@billyvg billyvg deleted the ref-feedback-change-form-box-shadow-css-var branch November 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants