Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add addEventProcessor method #9554

Merged
merged 4 commits into from Dec 4, 2023
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 14, 2023

And deprecate addGlobalEventProcessor() and getGlobalEventProcessors().

In v8, all event processors will be on the client only, streamlining this a bit and preventing global "pollution".

Closes #9082

@mydea mydea self-assigned this Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 65.87 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 59.47 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.12 KB (0%)
@sentry/browser - Webpack (gzipped) 21.38 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 62.88 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.62 KB (+0.33% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.69 KB (+0.45% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 197.88 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 89.73 KB (+0.47% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 64.71 KB (+0.66% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.29 KB (+0.22% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.24 KB (-0.02% 🔽)
@sentry/react - Webpack (gzipped) 21.42 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 82.96 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 48.21 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.17 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 74.52 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.72 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 71.13 KB (added)

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need migration docs in MIGRATION.md

@mydea
Copy link
Member Author

mydea commented Nov 22, 2023

Good point!

Small note, with the upcoming hub & scope changes this also means that we'll update this to put the event processors on the isolation scope instead of the client, but that doesn't affect this PR (as it is a future change, that we can do under the hood in v8)

And deprecate `addGlobalEventProcessor()` and `getGlobalEventProcessors()`.

In v8, all event processors will be on the client only, streamlining this a bit and preventing global "pollution".
@mydea mydea merged commit abbc57f into develop Dec 4, 2023
92 checks passed
@mydea mydea deleted the fn/addEventProcessor branch December 4, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v8] Replace addGlobalEventProcessor with addEventProcessor
2 participants