Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SvelteKit Vercel Adapter (without Edge Runtime) #8085

Closed
8 tasks done
Tracked by #6692
Lms24 opened this issue May 9, 2023 · 4 comments
Closed
8 tasks done
Tracked by #6692

Support SvelteKit Vercel Adapter (without Edge Runtime) #8085

Lms24 opened this issue May 9, 2023 · 4 comments
Assignees

Comments

@Lms24
Copy link
Member

Lms24 commented May 9, 2023

In a first step to fully support SvelteKit apps deployed on Vercel, we should add support for @sveltejs/adapter-vercel.

The first step here is to add a working configuration for uploading source maps and making everything work for lambda functions. This doesn not yet include support for the edge runtime as this requires some more changes in the monorepo (extracting the edge SDK, bundling changes) first.

Tasks

  1. Lms24
  2. ci-skip-cache
    Lms24
  3. Lms24
  4. Lms24
@wtachau
Copy link

wtachau commented May 10, 2023

Happy to beta test if it's helpful!

@Lms24 Lms24 self-assigned this May 22, 2023
Lms24 added a commit that referenced this issue May 30, 2023
First step for Vercel support: Detecting the used SvelteKit adapter.

(This currently does nothing other than detecting the adapter; next step
is to configure the source maps plugin correctly for the respective
adapters)

ref #8085
@Lms24
Copy link
Member Author

Lms24 commented Jun 1, 2023

Hi @wtachau we're releasing 7.54.0 in a few minutes. Feel free to let us know if you want to try it out and encountered issues.

@wtachau
Copy link

wtachau commented Jun 1, 2023

thanks @Lms24! Other than the issue you already responded to here, I see a number of these warnings in the Vercel build:

- warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/chunks/index.js.map)
--
11:39:27.945 | ~/chunks/index2.js (sourcemap at index2.js.map)
11:39:27.945 | ~/chunks/index2.js.map (no sourcemap ref)
11:39:27.945 | - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/chunks/index2.js.map)
11:39:27.945 | ~/chunks/index3.js (sourcemap at index3.js.map)
11:39:27.945 | ~/chunks/index3.js.map (no sourcemap ref)
11:39:27.945 | - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/chunks/index3.js.map)
11:39:27.945 | ~/chunks/index4.js (sourcemap at index4.js.map)
11:39:27.945 | ~/chunks/index4.js.map (no sourcemap ref)
11:39:27.945 | - warning: could not determine a source map reference (Could not auto-detect referenced sourcemap for ~/chunks/index4.js.map)

What's a good way to try and debug this?

@Lms24
Copy link
Member Author

Lms24 commented Jun 2, 2023

@wtachau thanks for reporting!

I just checked and for me, these files resolve with correct source maps when deploying to vercel.

14:59:29.576 | ~/chunks/index.js (sourcemap at index.js.map)
14:59:29.576 | ~/chunks/index2.js (sourcemap at index2.js.map)
14:59:29.577 | ~/chunks/index3.js (sourcemap at index3.js.map)

Which adapter are you using and do you have any specific adapter settings?

Since I'm on vacation for the next two weeks, would you mind opening a new issue so that my colleagues can pick it up and triage? Ideally, you could provide us a minimal reproduction example which we can use to debug. Thank you!

I'm going to close this issue in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants