Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay: Disable session replay if recording affects performance too greatly #8002

Closed
bruno-garcia opened this issue May 1, 2023 · 3 comments · Fixed by #8228
Closed

Replay: Disable session replay if recording affects performance too greatly #8002

bruno-garcia opened this issue May 1, 2023 · 3 comments · Fixed by #8228
Assignees

Comments

@bruno-garcia
Copy link
Member

We'll attempt to detect Session Replay recording overhead to gracefully downgrade Sentry off of Replay, into Errors and Performance monitoring only (or whatever is configured).

This should address:

@Ejdems666
Copy link

Hello, we are experiencing similar issue as #6946 for 1 specific form in our angular app. Because of that we had to disable the replays. This would enable us to use them again. When do you plan to release this?

@billyvg
Copy link
Member

billyvg commented May 31, 2023

@Ejdems666 We should have a release by next week, you can keep an eye on #8228 -- I'll be updating docs to reflect on some options while we work on better native solutions, but here are some things you can currently do:

  • you can use the block feature to block the form. This will prevent the mutations inside of that form from being recorded
  • when the mutationLimit PR above is released, it will record replay breadcrumbs when we detect > 750 mutations. The breadcrumbs will give you a specific number. You can use this to adjust the mutationLimit configuration option (which is set at a pretty high default currently of 10,000).

Also if your app is publicly accessible, it'd help me identify additional causes of perf regressions. Feel free to drop me a link if you're interested (billy at sentry.io) - thanks!

billyvg added a commit that referenced this issue May 31, 2023
…o regular feature (#8228)

Instead of taking a fullsnapshot when `mutationLimit` is reached, lets
be aggressive and stop the replay to ensure end-users are not negatively
affected performance wise.

The default for showing a breadcrumb is at 750 mutations, and the
default limit to stop recording is 10000 mutations.

Closes #8002
@Ejdems666
Copy link

@billyvg Thank you very much for this quick fix.
We'll test this in the upcoming weeks.
Unfortunatelly our app is not publicly accessible, hopefully further debugging won't be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants