-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
meta: Update changelog for 7.40.0 #7315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2,783
−11,076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
We do not want to run the instance initializer in fastboot env, as that relies on Browser stuff.
A newly added replay test (#7044) for checking for the presence of XHR/fetch request spans was flaky on CI. This was caused by two reasons: 1. We didn't explicitly await for the fetch/xhr requests to finish before waiting for the replay event which we expected to contain the span. With this fix we now wait that the browser actually received the response. 2. The tests were only flaky on Firefox. After some research (this seems to be somewhat of a [known problem](microsoft/playwright#11390 (comment)) in some situations) I decided to simply skip for FF. I think this is reasonably pragmatic as we're still testing on Chromium and Webkit.
Fix the flakiness of our replay event flushing test by slightly changing the test requirements/expectations: * Disabled compression to avoid potential timing problems * Instead of asserting that a flush happens within a certain time frame from the last flush, we ease up this expectation so that we only expect _that_ another flush happens after the previous one, given that click events happened in between. * Instead of forcing a flush by triggering a visibility change (like we do a lot in other tests to avoid flakes), this test focuses on the max delay of flushing, thereby ensuring that our flushes are not debounced to eternity.
…#7298) Change the way we listen to errors by directly try/catching the function instead of listening to the domain's error callback. Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
… function error events (#7301) Fix adding custom tags for GCP Background and CloudEvent function error events. As for Http functions, we also previously captured errors just via `domain.on('error',...)` which used the wrong domain, leading to tags (+other data) not being captured correctly. With this fix, we now also directly capture exceptions during function invocation.
Bumps [minimist](https://github.com/minimistjs/minimist) from 0.2.1 to 0.2.4. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v0.2.1...v0.2.4) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
* Revert "test(browser): Temporarily skip offline transport tests (#7305)" * test(core): Skip flaky offline transport test
Right now our Vue SDK doesn't log errors occurring in the Vue renderer to the console by default. Users need to manually set [`logErrors: true`](https://docs.sentry.io/platforms/javascript/guides/vue/#vue-3---manual-initialization) to enable logging of errors. After an internal discussion, we decided to log errors by default. Users can continue to use `logErrors` to opt out of that.
Lms24
approved these changes
Mar 1, 2023
size-limit report 📦
|
mydea
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.