Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel): Update installation instructions #6262

Merged
merged 4 commits into from Nov 22, 2022

Conversation

AbhiPrasad
Copy link
Member

  1. Convert from ES modules to require
  2. Specify to set the instrumenter option to turn off Sentry instrumentation
  3. Clean up imports
  4. Add sdk.start command to match otel docs: https://opentelemetry.io/docs/instrumentation/js/getting-started/nodejs/#setup

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.5 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.16 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 53.63 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.9 KB (0%)
@sentry/browser - Webpack (minified) 65.12 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.37 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.78 KB (+0.02% 🔺)

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) November 22, 2022 17:40
@AbhiPrasad AbhiPrasad merged commit 3fbf2a2 into master Nov 22, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-otel-instructions-update branch November 22, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants