Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add guard against scope.getAttachments #6258

Merged
merged 1 commit into from Nov 22, 2022

Conversation

AbhiPrasad
Copy link
Member

Fixes #5229 (comment)

We need to check for the existence of finalScope.getAttachments because getAttachments can be undefined if users are using an older version of @sentry/core that does not have the getAttachments method.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.52 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.39 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.18 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.74 KB (+0.04% 🔺)
@sentry/browser - Webpack (gzipped + minified) 19.91 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 65.2 KB (+0.03% 🔺)
@sentry/react - Webpack (gzipped + minified) 19.94 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.93 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.36 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.77 KB (+0.03% 🔺)

@AbhiPrasad AbhiPrasad merged commit 74810e0 into master Nov 22, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-guard-scope branch November 22, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with attachments API (getAttachments)
3 participants