Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support createHashRouter from React Router 6.4 #6251

Closed
onurtemizkan opened this issue Nov 21, 2022 · 2 comments · Fixed by #8362
Closed

Support createHashRouter from React Router 6.4 #6251

onurtemizkan opened this issue Nov 21, 2022 · 2 comments · Fixed by #8362

Comments

@onurtemizkan
Copy link
Collaborator

Problem Statement

React Router 6.4 introduced Data API, with 3 new ways to initialize a router:

We should support usage of createHashRouter for users that prefer it over createBrowserRouter.

Solution Brainstorm

Implementation should be fairly similar to createBrowserRouter, we should still be able to subscribe routing events.

Also need to check:

  • How would route parameterization work with hash urls?
  • Do we need a URL parser, or can we get declarative route info from subscription?

Alternatively we can also consider writing a wrapper for <RouterProvider>, which all three types of routers are rendered in.

@github-actions
Copy link
Contributor

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@pietrovismara
Copy link

We are stuck on this as we have to use the hash router.
Anyone could point me in the right direction to make sentry work with react-router@6.4+ createHashRouter?

I checked the PR to integrate createBrowserRouter and it doesn't look so complicated so I'm wondering if there is some fundamental difference in the way browser and hash routers should be handled by sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants