fix(core): Only generate eventIds in client #6247
Conversation
size-limit report 📦
|
packages/core/src/hub.ts
Outdated
| return (this._lastEventId = | ||
| this._withClient((client, scope) => { |
There was a problem hiding this comment.
l: Can we make this assignment a little clearer by first assigning this._lastEventId and then returning it? Or does this syntax save significantly more bundle size? Just asking because it took me a second to realize what's going on here
There was a problem hiding this comment.
yeah I was maybe overzealous with the bundle size saving here, will refactor.
| function makeClient() { | ||
| return { | ||
| getOptions: jest.fn(), | ||
| captureEvent: jest.fn(), | ||
| captureException: jest.fn(), | ||
| captureException: jest.fn().mockReturnValue(MOCK_EVENT_ID), |
There was a problem hiding this comment.
Where are we using this value? Couldn't find usage in the changed tests.
There was a problem hiding this comment.
MOCK_EVENT_ID is what hub.lastEventId() is being set as. It's not being directly asserted on, just used as a return value from captureException (so we can differentiate between undefined)
packages/hub/test/hub.test.ts
Outdated
|
|
||
| expect(args[2].event_id).toBeTruthy(); | ||
| const id = hub.captureMessage('a'); | ||
| expect(id).toBeTruthy(); |
There was a problem hiding this comment.
l: Probably related to my point above but can we check the id here for a more precise value than it being truthy or is this alright (totally your call, just asking)?
There was a problem hiding this comment.
All I care about is that this is not undefined, will adjust for that.
|
|
||
| expect(args[1].event_id).toBeTruthy(); | ||
| const id = hub.captureEvent(event); | ||
| expect(id).toBeTruthy(); | ||
| }); | ||
|
|
||
| test('should keep event_id from hint', () => { |
There was a problem hiding this comment.
Is this ("from hint") still correct?
This reverts commit 3fe5f7a.
Fixes #6244
This changes moves all generation of eventId uuids to the client. Since we can't change the signature of
hub.captureExceptionand similar, we return a event id of zeros,00000000000000000000000000000000, if the client method returns undefined.This should improve the performance of the SDKs!